-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve generated description from xml docs #1473
Improve generated description from xml docs #1473
Conversation
…ption from xml docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only a comment on the implementation. I'll leave it to others to comment on the general direction of this change.
Would it be simpler if the logic was integrated in |
The latest commit addresses those missing regex issues @drewnoakes mentioned. However, going down the path of changing the
Or did I misunderstand you? |
My comment was about not using a Regex at all. Trying to find these occurrences could be prone to errors if the content doesn't match for any reason we can't think of right now. Instead, just process the value when we detect it in |
…descs-in-configuration-schema-generator
…gEx to parsing time in "StripXmlElements" method
Sorry for the delay. |
Addresses: #1428
This PR uses a compiled regex to find and replace all namespaced types/methods/properties in a summary section in components' XML docs.
Microsoft Reviewers: Open in CodeFlow